Re: ext2, ext3, ext4 config headlines inconsistent:

From: Theodore Tso
Date: Thu Oct 16 2008 - 11:16:21 EST


On Tue, Oct 14, 2008 at 11:37:23AM -0700, Roland Dreier wrote:
> Hi Ted,
>
> While running an oldconfig with the new kernel, I got the following prompt:
>
> Second extended fs support (EXT2_FS) [N/m/y/?] n
> Ext3 journalling file system support (EXT3_FS) [N/m/y/?] n
> The Extended 4 (ext4) filesystem (EXT4_FS) [N/m/y/?] (NEW) n
>
> the lack of parallelism in the headline prompts is a little jarring.
> Any interest in a patch to make this look uniform, or is it not worth
> it? If you are interested, which variant do you prefer?

I'll note that we don't have consistency across all of the entries in
fs/Kconfig, not just ext2/ext3/ext4. If it were just up to me I'd
probably prefer:

Ext2 file system support (EXT2_FS) [N/m/y/?] n
Ext3 file system support (EXT3_FS) [N/m/y/?] n
Ext4 file system support (EXT4_FS) [N/m/y/?] (NEW) n

... but it might be worth looking at the other entries in fs/Kconfig
as well.

- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/