Re: [PATCH] Fix broken debug output reserve_region_with_split()

From: David Miller
Date: Fri Oct 17 2008 - 01:21:44 EST


From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Thu, 16 Oct 2008 21:18:08 -0700 (PDT)

> I dunno. I'd certainly be perfectly happy with having the flags and
> field_width be specified by the resource flags. eg
>
> flags = ZEROPAD | SMALL;
> fieldwidth = (res->flags & IORESOURCE_IO) ? 4 : 8;
>
> or something like that. But would it be acceptable to everybody?

I personally appreciate seeing the full 64-bit address on sparc64,
even for IORESOURCE_IO, and that's helped me debug resource
calculation bugs on more than one occasion in the past.

But that's just me :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/