Re: [PATCH] sched: fix the wrong mask_len

[KOSAKI Motohiro]

> ---
> Subject: sched: fix the wrong mask_len
> From: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Date: Fri Oct 17 12:55:57 CEST 2008
> 
> If the NR_CPUS isn't a multiple of 32, we get a truncated string of sched
> domains by catting /proc/schedstat. This is caused by the wrong mask_len.
> 
> Reported-by: Miao Xie <miaox@xxxxxxxxxxxxxx>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> ---
>  kernel/sched_stats.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/kernel/sched_stats.h
> ===================================================================
> --- linux-2.6.orig/kernel/sched_stats.h
> +++ linux-2.6/kernel/sched_stats.h
> @@ -9,7 +9,7 @@
>  static int show_schedstat(struct seq_file *seq, void *v)
>  {
>  	int cpu;
> -	int mask_len = NR_CPUS/32 * 9;
> +	int mask_len = DIV_ROUND_UP(NR_CPUS, 32) * 9;
>  	char *mask_str = kmalloc(mask_len, GFP_KERNEL);
>  
>  	if (mask_str == NULL)

Acked-by: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/