Re: [PATCH] atmel_lcdfb: unsigned irq_base cannot be negative
From: Nicolas Ferre
Date: Tue Oct 21 2008 - 04:46:20 EST
Hi,
roel kluin :
unsigned irq_base cannot be negative
Indeed. Thanks for taking this point !
Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
---
diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index f8d0a57..f93f57a 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -857,12 +857,12 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev)
goto stop_clk;
}
- sinfo->irq_base = platform_get_irq(pdev, 0);
- if (sinfo->irq_base < 0) {
+ ret = platform_get_irq(pdev, 0);
+ if (ret < 0) {
dev_err(dev, "unable to get irq\n");
- ret = sinfo->irq_base;
goto stop_clk;
}
+ sinfo->irq_base = ret;
I prefer changing the definition of irq_base to plain int.
So the patch becomes obvious:
- unsigned long irq_base;
+ int irq_base;
What do you think of this ?
I repost a patch addressing this issue.
Regards,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/