Re: [PATCH] Make static

From: Ingo Molnar
Date: Wed Oct 22 2008 - 02:19:12 EST



* roel kluin <roel.kluin@xxxxxxxxx> wrote:

> Make static
>
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> ---
>
> Building an allnoconfig, sparse asked whether these could be static,
> so I checked, and they are only used in the file where they are
> declared. This means that they can be static, am I forgetting
> something? This was build and checkpatch tested.

yeah, it's correct!

> arch/x86/boot/video-bios.c | 4 ++--
> arch/x86/boot/video-vesa.c | 4 ++--
> arch/x86/kernel/xsave.c | 2 +-

i've applied these bits to tip/x86/urgent,

> kernel/irq/proc.c | 2 +-

this bit to tip/irq/urgent,

> kernel/printk.c | 2 +-

and this bit to tip/core/urgent.

Thanks Roel,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/