Re: [PATCH 4/7] gpiolib: implement dev_gpiochip_{add,remove} calls
From: David Brownell
Date: Thu Oct 23 2008 - 02:15:40 EST
On Wednesday 22 October 2008, Anton Vorontsov wrote:
> --- a/drivers/gpio/pcf857x.c
> +++ b/drivers/gpio/pcf857x.c
> @@ -187,7 +187,7 @@ static int pcf857x_probe(struct i2c_client *client,
> struct pcf857x *gpio;
> int status;
>
> - pdata = client->dev.platform_data;
> + pdata = pcf857x_get_pdata(client);
> if (!pdata)
> return -ENODEV;
>
I suppose that can work. Regardless, some OF-specific code will
need to map device tree state into a generic format that's fully
decoupled from OF. (And there's something to be said to having
that mapping sit in the same directory as the driver needing it.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/