Re: [PATCH 0/4][RFC] netns: sysfs: add a netns suffix to net devicesysfs entries

From: Benjamin Thery
Date: Thu Oct 23 2008 - 08:00:45 EST


Eric W. Biederman wrote:
Benjamin Thery <benjamin.thery@xxxxxxxx> writes:

Support for network namespaces in mainline is pretty complete for
some time now, but there is still this issue with sysfs that prevents more people to use it easily.

Ben your patchset is completely inappropriate.

Temporarily adding elements to the ABI that we intend to remove
is not a proper solution to this problem.

In fact, I feared that would be an issue before I sent the patches.
Thanks for confirming this.

But, as this alternative was discussed a bit after Al's comments on your
last patches, I had to give it a try and code a proof-of-concept.

Benjamin


That user space visible ida you add is a namespace identifier that breaks
nested containers and migration. It is very very very wrong.

Eric





--
B e n j a m i n T h e r y - BULL/DT/Open Software R&D

http://www.bull.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/