Re: Adding kmap_atomic_prot_pfn (was: [git pull] drm patches for2.6.27-rc1)

From: Linus Torvalds
Date: Fri Oct 24 2008 - 10:55:35 EST




On Thu, 23 Oct 2008, Keith Packard wrote:
>
> I'm fine with sticking the mapping in a separate structure; it's just
> the return from ioremap_wc on 64-bit systems, and nothing at all on
> 32-bit systems.

Actually, on 32-bit, the 'prot' should be there, as should the starting
physical page. Otherwise the two interfaces would be very odd, and you'd
have to repeat those arguments in all callers (ie both in "prepare" and
in the actual "access").

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/