Re: [PATCH] Skip tsc synchronization checks if CONSTANT_TSC bit is set.

From: Andi Kleen
Date: Fri Oct 24 2008 - 15:26:46 EST


On Fri, Oct 24, 2008 at 12:19:41PM -0700, H. Peter Anvin wrote:
> Andi Kleen wrote:
> >
> >In the field they will just continue using clock=pit, like they
> >always did on vmware. And also they will not update the Linux kernel.
> >
>
> That is a totally bogus assumption. You will typically have the host
> platform (Vmware in this case) move much much slower than the guests.

The people running on older hypervisors will just continue using
PIT timer. They won't get nohz, but i guess without updates
they don't expect new features.

> >This is strictly for new installations. And I frankly don't
> >see why Linux needs to get white listed workarounds when the
> >Hypervisor couldn't as well be fixed. We have the bizarre
> >situation here where a HV vendor tries to add workarounds
> >to Linux instead of fixing it on their products.
>
> ... just like every other hardware vendor.

Hardware vendors can't fix it without long lead time.
Software vendors can as easily as Linux.

Also we're talking about an optimization here (enabling NOHZ), not a
correctness issue. So your analogy to hardware workarounds
is already dubious.

-Andi
--
ak@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/