Re: Adding kmap_atomic_prot_pfn

[Thomas HellstrÃm]

Keith Packard wrote:
> On Fri, 2008-10-24 at 09:33 +0200, Thomas HellstrÃm wrote:
>   
> > Keith,
> >
> > What you actually are doing here is claiming copyright on code that 
> > other people have written, and tighten the export restrictions. 
> > kmap_atomic_prot_pfn() appeared long ago in drm git with identical code 
> > and purpose, but with different authors, and iounmap_atomic is identical 
> > to kunmap_atomic.
> >     
>
> Yeah, I just stuck my usual license header on it and didn't think about
> authorship. I'll fix that, once we figure out what the appropriate name
> is.
>
> But, as this code is clearly a trivial adaptation of the existing kernel
> code, it should carry a GPLv2 license. I'm also not particular as to the
> EXPORT restriction, I was just following the EXPORT advice given for the
> other newly exposed kernel symbols we're using.
>
>   
Thanks, Keith.

If there is a chance that people who do want the EXPORT_SYMBOL_GPL 
restriction are OK to go with just EXPORT_SYMBOL(), I guess that would 
fit best considering what's already exported and doable in drivers today.

/Thomas








--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/