Re: [PATCH RESEND] vgacon: remember scrollback buffer on consoleswitch

From: Andrew Morton
Date: Sat Oct 25 2008 - 19:15:38 EST


On Sun, 26 Oct 2008 00:43:01 +0200 Marcin Slusarz <marcin.slusarz@xxxxxxxxx> wrote:

> PS: why DECLARE_MUTEX _defines_ _semaphore_?

The kernel gets definition-vs-declaration confused in several places.

> there are only 8 uses of this
> macro so it's not a big problem to rename it to e.g. DEFINE_SEMAPHORE (I can
> provide a patch)

I'd say that s/declare/define/ at such a late stage in the semaphore's
lifetime would be of dubious value. But getting "MUTEX" out of that
macro's name would be a very good thing - it's a bad overlap with struct
mutex. Send patch :)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/