Re: [PATCH] vfs: Fix possible chmod/truncate race condition.

[Andrew Morton]

On Wed, 15 Oct 2008 23:35:27 +0400 Dmitri Monakhov <dmonakhov@xxxxxxxxxx> wrote:

> 
> Signed-off-by: Dmitri Monakhov <dmonakhov@xxxxxxxxxx>
> ---
>  fs/open.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/open.c b/fs/open.c
> index 07da935..3423b94 100644
> --- a/fs/open.c
> +++ b/fs/open.c
> @@ -214,10 +214,9 @@ int do_truncate(struct dentry *dentry, loff_t length, unsigned int time_attrs,
>  		newattrs.ia_valid |= ATTR_FILE;
>  	}
>  
> +	mutex_lock(&dentry->d_inode->i_mutex);
>  	/* Remove suid/sgid on truncate too */
>  	newattrs.ia_valid |= should_remove_suid(dentry);
> -
> -	mutex_lock(&dentry->d_inode->i_mutex);
>  	err = notify_change(dentry, &newattrs);
>  	mutex_unlock(&dentry->d_inode->i_mutex);
>  	return err;

OK, I give up.  What race?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/