RE: CONFIG_LEDS_DA903X=m breaks 2.6.28-rc2-git1 build on x86-64

[Eric Miao]

This is strange, it compiles OK on ARM, I don't know why this
failed on x86-64. But anyway, <linux/workqueue.h> should really
be explicitly included here.

The attached patch should fix this.

- eric

-----Original Message-----
From: Jean Delvare [mailto:khali@xxxxxxxxxxxx] 
Sent: Monday, October 27, 2008 4:45 PM
To: Mike Rapoport; Eric Miao; Richard Purdie
Cc: LKML; Linus Torvalds
Subject: CONFIG_LEDS_DA903X=m breaks 2.6.28-rc2-git1 build on x86-64

Hi Mike, Eric, Richard,

With CONFIG_LEDS_DA903X=m, kernel 2.6.28-rc2-git1 fails to build on
x86-64 with the following error:

  CC [M]  drivers/leds/leds-da903x.o
drivers/leds/leds-da903x.c:35: error: field "work" has incomplete type
drivers/leds/leds-da903x.c: In function "da903x_led_work":
drivers/leds/leds-da903x.c:47: warning: type defaults to "int" in
declaration of "__mptr"
drivers/leds/leds-da903x.c:47: warning: initialization from incompatible
pointer type
drivers/leds/leds-da903x.c: In function "da903x_led_set":
drivers/leds/leds-da903x.c:89: error: implicit declaration of function
"schedule_work"
drivers/leds/leds-da903x.c: In function "da903x_led_probe":
drivers/leds/leds-da903x.c:125: error: implicit declaration of function
"INIT_WORK"

Can we PLEASE stick to the plan and ONLY have bug FIXES after rc1 (and
even more so after rc2)?

Thanks,
-- 
Jean Delvare

Attachment: 0001-leds-da903x-fix-the-building-failure-of-incomplete.patch
Description: 0001-leds-da903x-fix-the-building-failure-of-incomplete.patch