Re: [PATCH 1/2] Add c2 port support.

From: Greg KH
Date: Mon Oct 27 2008 - 12:16:40 EST


On Mon, Oct 27, 2008 at 09:54:14AM +0100, Rodolfo Giometti wrote:
> On Thu, Oct 23, 2008 at 08:37:33AM -0700, Greg KH wrote:
>
> > And again, you can still use sysfs for that as well. I was just
> > referring to the binary sysfs file that you use for the firmware
> > download, it would make more sense for you to use the standard kernel
> > firmware download interface instead of rolling your own here.
>
> If I well understand the firmware class it works starting the firmware
> download from the kernel side, that is into the kernel we should call
> request_firmware() and then the files will
> /sys/class/firmware/xxx/{loading,data} appear.

Yes, that is true, but userspace doesn't have to write to those files
until it feels like it.

> This solution doesn't fit C2 port needs since the firmware download is
> decided from userland erasing and then writing into the
> microcontroller on-board flash.

That's fine, you can still use the same interface, no problems. Just
use the "async" version of the firmware interfae and you will be fine.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/