Re: [PATCH tip/tracing/markers] new probes manager

[Ingo Molnar]

* Mathieu Desnoyers <compudj@xxxxxxxxxxxxxxxxxx> wrote:

> * Mathieu Desnoyers (mathieu.desnoyers@xxxxxxxxxx) wrote:
> > * Lai Jiangshan (laijs@xxxxxxxxxxxxxx) wrote:
> > > 
> > > this patch use a new probes manager for marker.
> > > 
> > > the most important benefit of this patch is:
> > > 	1) smp_rmb() is removed from the critical path. as we know rmb()
> > > 	   is very expensive.
> > > 
> > 
> > Do you have performance measurements for this ? On x86 it's a nop,
> > AFAIK.
> 
> My statement above is inexact : x86_64 uses lfence for rmb(). But
> numbers would still be welcome.

yes, the statement that rmb() is very expensive looks dubious. It is 
absolutely cheap everywhere.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/