Re: [RFC PATCHv3] printk: add %pM format specifier for MACaddresses

From: Alexey Dobriyan
Date: Mon Oct 27 2008 - 19:28:45 EST


On Mon, Oct 27, 2008 at 04:14:14PM -0700, Harvey Harrison wrote:
> On Mon, 2008-10-27 at 15:47 -0700, David Miller wrote:
> > From: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> > Date: Mon, 27 Oct 2008 12:59:02 -0700
> >
> > > Add format specifiers for printing out six colon-separated bytes:
> > >
> > > MAC addresses (%pM):
> > > xx:xx:xx:xx:xx:xx
> > >
> > > %#pM is also supported and omits the colon separators.
> > >
> > > Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
> >
> > Applied, thanks.
>
> Did you happen to have a preference with regard to the specifier for
> IPv6 addresses:
>
> I was thinking of using %pI6 to replace NIP6() and NIP6_FMT and using
> %#pI6 for NIP6_SEQFMT.
>
> On the IPv4 side, maybe use %pI4 for network endian NIPQUAD() and NIPQUAD_FMT
> and then %#pI4 for host-endian HIQUAD(), as displaying the IPv4 address without
> the periods isn't useful?

%#pI4 is horrible and %p4 and %p6 were cool.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/