Re: [Patch 2.6.27] fix booting on Sharp Zaurus c3000

From: Russell King
Date: Tue Oct 28 2008 - 04:45:46 EST


On Mon, Oct 27, 2008 at 11:42:46PM -0700, Andrew Morton wrote:
> On Mon, 27 Oct 2008 09:25:12 -0700 Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> > On Sun, 26 Oct 2008 19:41:09 +0100
> > Pavel Machek <pavel@xxxxxxx> wrote:
> > > Yes, I guess it should go to stable.
> > >
> > > commit 69fc7eed5f56bce15b239e5110de2575a6970df4
> > > Author: Dmitry Baryshkov <dbaryshkov@xxxxxxxxx>
> > > Date: Thu Oct 9 16:58:13 2008 +0100
> > >
> > > [ARM] 5300/1: fixup spitz reset during boot
>
> Somebody applied this.

Yes, I did, on October 11th.

> > > +/**
> > > + * init_gpio_reset() - register GPIO as reset generator
> > > + *
> > > + * @gpio - gpio nr
> > > + * @output - set gpio as out/low instead of input during normal work
> >
> > Use colon (':') after function parameters, not hyphen/dash.
>
> Without doing that.

Comments received after the patch has been committed and sent to
Linus can't be retrospectively corrected. Another patch is required.

Since it's a trivial documentation matter, don't we have someone
handling such patches? Is Rusty still the Trivial Patch Monkey?

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/