Re: [PATCH] fork.c: fix a problem of code style

[Andrew Morton]

On Wed, 22 Oct 2008 03:02:21 +1030
David Newall <davidn@xxxxxxxxxxxxxxx> wrote:

> Jianjun Kong wrote:
> > -	if(max_threads < 20)
> > +	if (max_threads < 20)
> 
> I thought we didn't bother with trivial style changes like this.

Yes, it's too small:

akpm:/usr/src/25> perl scripts/checkpatch.pl --file kernel/fork.c | grep total
total: 34 errors, 13 warnings, 1689 lines checked

We could merge thousands and thousand of one-line patches like this and
it's all very inefficient.

I'd consider larger patches which cleaned up whole subdirectories. 
They're not much fun to maintain but we don't regret these things after
we've done them.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/