Re: [patch 2.6.28-rc2] atmel_serial: keep clock off when it's notneeded

[Haavard Skinnemoen]

David Brownell <david-b@xxxxxxxxxxx> wrote:
> On Tuesday 28 October 2008, Andrew Victor wrote:
> > hi David,
> > 
> > > I verified it on AT91, where the console is normally DBGU and the
> > > other USARTs do get an open().
> > 
> > The DBGU is part of the system peripherals, which are clocked from MCK
> > and which is always enabled.
> 
> Exactly.

Exactly what? That your patch has exactly zero effect on your test case?

> > Therefore I don't think this is a valid test-case.
> 
> Not for the oddball case Haavard mentioned, no:  the console port
> being something the boot loader wasn't using, which couldn't show
> the early boot messages (before console setup) in any case.  Those
> kinds of systems aren't especially debuggable (it's JTAG or nothing).

Since when is it acceptable to lock up solid in "oddball" cases? Not to
mention that I don't think this is an "oddball" case at all -- the
bootloader has absolutely _no_ way of influencing the initial enable
count of the clock, so the kernel will turn it off as soon as it gets
the chance.

The oddball case is when the clock happens to be shared with
peripherals that are always enabled. Then it doesn't matter if the
clock management in atmel_serial is screwed up.

> I don't have any issue with getting that fixed too ... but unless
> someone has a platform that relies on that case (or can be made to
> do so, for testing), then it's hard for me to worry about it!

David, I can't believe you're taking such an easy attitude towards
basic correctness!

I agree that the clock management is already wrong, but keeping a
couple of clocks enabled when they could have been disabled is far less
of a problem than locking up the console.

I also understand if you don't want to fix the console issue I pointed
out, but I'm surprised that you aren't even willing to acknowledge the
problem, brushing it off with words like "normally" and "as a rule".

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/