Re: [PATH -mm -v2] Fix a race condtion of oops_in_progress

From: Chris Snook
Date: Wed Oct 29 2008 - 10:53:02 EST


Huang Ying wrote:
Fix a race condition accessing oops_in_progress. Which may be changed on
multiple CPU simultaneously, but it is changed via non-atomic operation
++/--. This patch changes the definition of oops_in_process from int to
atomic_t, and accessing method to atomic operations.

You also need barriers. I believe rmb() before atomic_read() and wmb() after atomic_set() should suffice.

-- Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/