Re: [PATCH][RFC] x86: add non x86 build configuration

From: Steven Rostedt
Date: Thu Oct 30 2008 - 17:09:37 EST



On Thu, 30 Oct 2008, Ingo Molnar wrote:
> >
> > Hmm, I made it a choice, with the "Normal Config" as default, so
> > that allyesconfig will not set it. Does it get set for you when you
> > do an allyesconfig? I had to do the following:
>
> hm, indeed.
>
> Still ... the Kconfig glue looks a bit weird - it's almost never a
> good idea to put 'NOT' (or any other logic operator) into a config
> name. Why not make this CONFIG_STANDARD_X86_FEATURES and allow it to

OK

> be disabled when CONFIG_EMBEDDED is enabled? This way it's not just a
> debug thing but also a kernel sizing feature.

But this affects other things than simply bloat features, like:

select HAVE_AOUT if X86_32
select HAVE_UNSTABLE_SCHED_CLOCK
select HAVE_IDE
select HAVE_GENERIC_DMA_COHERENT if X86_32
select HAVE_EFFICIENT_UNALIGNED_ACCESS

Having an option that lets EMBEDDED turn off some of the above might be
confusing.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/