Re: [PATCH 1/1] USBHID: correct start/stop cycle

From: Helge Deller
Date: Sun Nov 02 2008 - 05:44:13 EST


Jiri Slaby wrote:
On 11/02/2008 12:02 AM, Jiri Kosina wrote:
On Sat, 1 Nov 2008, Jiri Slaby wrote:

`stop' left out usbhid->urb* pointers and so the next `start' thought
it needs to allocate nothing and used the memory pointers previously
pointed to. This led to memory corruption and device malfunction.
[...]
could you please verify whether this patch fixes the corruption you were experiencing?

btw. this is not expected to fix that, but if it does, the better ;).

I tried the patch and sadly it didn't fixed the parisc bug.

Helge

This fixes
echo DEVICE > /sys/bus/hid/drivers/DRIVER/unbind
echo DEVICE > /sys/bus/hid/drivers/DRIVER/bind
failures.

But maybe parisc does something differently than x86 in bus handling so that it
triggers...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/