Re: [PATCH] Identify which executable object the userspace addressbelongs to. Store thread group leader id, and use it to lookup theaddress in the process's map. We could have looked up the addresson thread's map, but the thread might not exist by the time we arecalled. The process might not exist either, but if you are readingtrace_pipe, that is unlikely.

From: Al Viro
Date: Sun Nov 02 2008 - 16:25:34 EST


On Sun, Nov 02, 2008 at 11:18:14PM +0200, T??r??k Edwin wrote:
> +static int
> +trace_seq_path(struct trace_seq *s, struct path *path)
> +{
> + int ret;
> + struct seq_file m;
> + m.count = s->len;
> + m.size = PAGE_SIZE;
> + m.buf = s->buffer;
> + ret = seq_path(&m, path, "\n");
> + if (ret)
> + s->len = m.count;
> + return ret;
> +}

NAK. seq_path() is a blatantly wrong thing to use here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/