Re: [PATCH] Add option to passively listen for PCIE hotplug events

[Matthew Garrett]

On Tue, Nov 04, 2008 at 02:46:20PM +0900, Kenji Kaneshige wrote:

> I can't understand why the 'value' is set to 0 when pciehp_enable_slot()
> returns error. The 'value' here is representing whether the slot is
> occupied or not. Even if pciehp_enable_slot() returns error, it doesn't
> mean slot is not occupied. So I think it is clearly wrong thing that
> changing 'value' to 0 from 1 here.
> 
> How about just ignore the return value from pciehp_enable_slot()? The
> code would be as follows.

Yeah, I agree with that.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/