Re: [PATCH] sparse_irq aka dyn_irq v10

From: Ingo Molnar
Date: Mon Nov 10 2008 - 04:57:40 EST



* Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

> Ingo Molnar wrote:
> > * Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> >
> >> +#ifdef CONFIG_SPARSE_IRQ
> >> +static void uv_ack_apic_wrapper(unsigned int irq, struct irq_desc **descp)
> >> +#else
> >> +static void uv_ack_apic_wrapper(unsigned int irq)
> >> +#endif
> >
> > hm, why not change it to the new prototype unconditionally? (just pass
> > in NULL or so)
>
> that is sitting on irq_chip, and if change that, we need to go over
> all those kind of funcs and structure of other platforms.

okay, lets not go there just yet.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/