[PATCH 2/2] x86: Fixing improper annotation.

From: Rakib Mullick
Date: Mon Nov 10 2008 - 23:21:38 EST


After using __cpuinit in function 'init_thread_xstate(void)', the
following warning was generated.

WARNING: arch/x86/kernel/built-in.o(.cpuinit.text+0x29c): Section
mismatch in reference from the function init_thread_xstate() to the
function .init.text:xsave_cntxt_init()
The function __cpuinit init_thread_xstate() references
a function __init xsave_cntxt_init().
If xsave_cntxt_init is only used by init_thread_xstate then
annotate xsave_cntxt_init with a matching annotation.

WARNING: arch/x86/kernel/built-in.o(.cpuinit.text+0x233d): Section
mismatch in reference from the function cpu_init() to the function
.init.text:xsave_init()
The function __cpuinit cpu_init() references
a function __init xsave_init().
If xsave_init is only used by cpu_init then
annotate xsave_init with a matching annotation.

Signed-off-by: Rakib Mullick <rakib.mullick@xxxxxxxxx>

--- linux-2.6-orig/arch/x86/kernel/xsave.c 2008-11-10 13:28:18.000000000 +0600
+++ linux-2.6/arch/x86/kernel/xsave.c 2008-11-11 00:31:42.000000000 +0600
@@ -301,7 +301,7 @@ void __cpuinit xsave_init(void)
/*
* setup the xstate image representing the init state
*/
-static void __init setup_xstate_init(void)
+static void __cpuinit setup_xstate_init(void)
{
init_xstate_buf = alloc_bootmem(xstate_size);
init_xstate_buf->i387.mxcsr = MXCSR_DEFAULT;
@@ -310,7 +310,7 @@ static void __init setup_xstate_init(voi
/*
* Enable and initialize the xsave feature.
*/
-void __init xsave_cntxt_init(void)
+void __cpuinit xsave_cntxt_init(void)
{
unsigned int eax, ebx, ecx, edx;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/