Re: rc4-mmotm1110 - Another build error

[Andrew Morton]

On Tue, 11 Nov 2008 15:54:38 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:

> On Mon, 10 Nov 2008 19:43:53 -0800
> Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Mon, 10 Nov 2008 22:20:33 -0500 Valdis.Kletnieks@xxxxxx wrote:
> > 
> > > gcc --version says:
> > > gcc (GCC) 4.3.2 20081105 (Red Hat 4.3.2-7)
> > > 
> > > ka-blam number 2:
> > > 
> > >   CC      kernel/audit.o
> > > In file included from include/net/dst.h:15,
> > >                  from include/net/sock.h:57,
> > >                  from kernel/audit.c:54:
> > > include/net/neighbour.h:114: error: braced-group within expression allowed only inside a function
> > > make[1]: *** [kernel/audit.o] Error 1
> > > 
> > > I'm placing bets on patches/align-avoid-evaluating-its-argument-twice.patch
> > > 
> > > Yep, revert that patch, and audit.o compiles again.
> > > 
> > 
> > I hadn't got around to testing that one yet.
> > 
> > So ug.  ALIGN() is used in array sizing and hence has to be a
> > compile-time thing.  But ALIGN(foo, bar()) will call bar() twice.
> > 
> > Now how do we fix that?
> 
> How about provoding
>   - ALIGN()  - args can be evaluated twice.

Well.  The problem here is the risk of mistakes, and such an ALIGN()
could still be called by mistake.

>  and
>   - static inline unsigned long align()

ALIGN() is designed so that it can take any scalar types as arguments
and still do the right thing, so it can't really be implemented as an
inline.

> messy ?

I suppose we could switch all those ALIGN calls which must occur at
compile-time over to a new STATIC_ALIGN() (?) which is allowed to
evaluate its args twice, then fix ALIGN().

A bit of a pain, but any missed conversions would reliably fail to
compile and would get fixed quickly.

hm, ALIGN() is used in assembly too, but it means something totally
different, sigh.

<greps>

./arch/x86/mm/hugetlbpage.c:    addr = ALIGN(start_addr, huge_page_size(h));
./arch/x86/mm/hugetlbpage.c:            addr = ALIGN(vma->vm_end, huge_page_size(h));
./arch/x86/mm/hugetlbpage.c:            addr = ALIGN(addr, huge_page_size(h));

These will presently be calling huge_page_size() twice.

Will these:

./drivers/mtd/ubi/build.c:	ubi->ec_hdr_alsize = ALIGN(UBI_EC_HDR_SIZE, ubi->hdrs_min_io_size);
./drivers/mtd/ubi/build.c:	ubi->vid_hdr_alsize = ALIGN(UBI_VID_HDR_SIZE, ubi->hdrs_min_io_size);

do the dereference twice?  Probably not.

I didn't immediately spot any bugs, but I didn't look very closely. 
Hopefully if there are any there, we'd have heard about it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/