Re: [git pull] drm fixes for 2.6.27-rc5

From: Jesse Barnes
Date: Tue Nov 11 2008 - 13:14:03 EST


On Tuesday, November 11, 2008 12:37 am Dave Airlie wrote:
> On Tue, Nov 11, 2008 at 6:29 PM, Andrew Morton
>
> <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > On Tue, 11 Nov 2008 08:15:26 +0000 (GMT) Dave Airlie <airlied@xxxxxxxx>
wrote:
> >> commit 78538bf14995a136c2d9a22159ada49937359119
> >> Author: Dave Airlie <airlied@xxxxxxxx>
> >> Date: Tue Nov 11 17:56:16 2008 +1000
> >>
> >> drm/radeon: map registers at load time
> >>
> >> Now that the radeon driver has suspend/resume functions, it needs to
> >> map its registers at load time or it will likely crash if a suspend
> >> operation occurs before the driver has been initialized.
> >>
> >> This patch moves the register mapping code from firstopen to load
> >> and makes the mapping into a _DRM_DRIVER one so that the core won't
> >> remove it at lastclose time.
> >
> > Does this make the below patch obsolete?
>
> Yes please drop this, the correct fix is the one Jesse posted + a fix
> on top of it I made in the same patch.

Oh geez, yeah that's ugly, thanks for catching it.

Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/