Re: [PATCH][mmotm] Sched fix stale value in average load per task

From: Ingo Molnar
Date: Wed Nov 12 2008 - 06:46:42 EST



* Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:

> * Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> [2008-11-12 16:19:00]:
>
> > + else
> > + rq->avg_load_per_task = 0;
> >
> > return rq->avg_load_per_task;
>
> On second thoughts, does this look better? (Based on Mike
> Galbraith's suggestion)

yes - but could you send it as a delta patch against your previous
patch please? We want the simpler patch for tip/sched/urgent, as a
v2.6.28 fix - the removal of rq->avg_load_per_task can wait until
v2.6.29. (Please also include Mike's Ack in the patch if he acks the
patch.)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/