Re: [PATCH 2/2] x86: ia32_signal: remove unnecessary padding

From: Andi Kleen
Date: Wed Nov 12 2008 - 07:39:01 EST


Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx> writes:

> From: Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx>
>
> Impact: cleanup

Actually it's not a cleanup.

> Remove unnecessary paddings, this saves 4 bytes.

This might actually break code. The code is not actually used,
but only kept around because some old gdb versions used this
code as a marker for detecting signals.

I don't know if they require the padding or not, but it seems
somewhat risky to change a legacy marker like this.

-Andi

--
ak@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/