Re: [PATCH 5/7] kprobes: Remove called_from argument

From: Masami Hiramatsu
Date: Wed Nov 12 2008 - 10:37:58 EST


Hi Ananth,

Ananth N Mavinakayanahalli wrote:
>
> You also need the following to get this to compile, don't you?

Oops, Indeed.
Thank you very much!
Where I've lost this parts...?

> Signed-off-by: Ananth N Mavinakayanahalli <ananth@xxxxxxxxxx>

Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

>
> Index: linux-2.6.28-rc4/kernel/kprobes.c
> ===================================================================
> --- linux-2.6.28-rc4.orig/kernel/kprobes.c 2008-11-12 11:13:30.000000000 +0530
> +++ linux-2.6.28-rc4/kernel/kprobes.c 2008-11-12 12:18:44.000000000 +0530
> @@ -666,8 +666,6 @@
> */
> probed_mod = __module_text_address((unsigned long) p->addr);
> if (probed_mod) {
> - struct module *calling_mod;
> - calling_mod = __module_text_address(called_from);
> /*
> * We must hold a refcount of the probed module while updating
> * its code to prohibit unexpected unloading.

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@xxxxxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/