Re: [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range

From: Jeremy Fitzhardinge
Date: Thu Nov 13 2008 - 21:56:21 EST


Nick Piggin wrote:

This isn't performance critical to anyone?

The only difference should be between having the specialized code and an indirect function call, no?

I see DRM, IB, GRU, other media and video drivers use it.

It IS exactly what apply_to_page_range does, I grant you. But so does
our traditional set of nested loops. So is there any particular reason
to change it? You're not planning to change fork/exit next, are you? :)

No ;) But I need to have a more Xen-specific version of remap_pfn_range, and I wanted to 1) have the two versions look as similar as possible, and 2) not have a pile of duplicate code.

J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/