Re: [PATCH 04 of 38] swiotlb: move some definitions to header

From: FUJITA Tomonori
Date: Sun Nov 16 2008 - 22:49:33 EST


On Thu, 13 Nov 2008 11:10:02 -0800
Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

> From: Ian Campbell <ian.campbell@xxxxxxxxxx>
>
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> ---
> include/linux/swiotlb.h | 14 ++++++++++++++
> lib/swiotlb.c | 14 +-------------
> 2 files changed, 15 insertions(+), 13 deletions(-)
>
> diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h
> --- a/include/linux/swiotlb.h
> +++ b/include/linux/swiotlb.h
> @@ -7,6 +7,20 @@
> struct dma_attrs;
> struct scatterlist;
>
> +/*
> + * Maximum allowable number of contiguous slabs to map,
> + * must be a power of 2. What is the appropriate value ?
> + * The complexity of {map,unmap}_single is linearly dependent on this value.
> + */
> +#define IO_TLB_SEGSIZE 128
> +
> +
> +/*
> + * log of the size of each IO TLB slab. The number of slabs is command line
> + * controllable.
> + */
> +#define IO_TLB_SHIFT 11
> +

Why do we need to export IO_TLB_SEGSIZE and IO_TLB_SHIFT to everyone
in include/linux?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/