Re: [patch 25/46] V4L/DVB (9624): CVE-2008-5033: fix OOPS ontvaudio when controlling bass/treble

From: Mauro Carvalho Chehab
Date: Mon Nov 17 2008 - 08:34:39 EST



On Sun, 16 Nov 2008 23:15:51 -0800
Greg KH <gregkh@xxxxxxx> wrote:

> 2.6.27-stable review patch. If anyone has any objections, please let us know.
>
> ------------------
>
> From: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
>
> commit 01a1a3cc1e3fbe718bd06a2a5d4d1a2d0fb4d7d9 upstream.
>
> This bug were supposed to be fixed by 5ba2f67afb02c5302b2898949ed6fc3b3d37dcf1,
> where a call to NULL happens.
>
> Not all tvaudio chips allow controlling bass/treble. So, the driver
> has a table with a flag to indicate if the chip does support it.
>
> Unfortunately, the handling of this logic were broken for a very long
> time (probably since the first module version). Due to that, an OOPS
> were generated for devices that don't support bass/treble.

Just complementing, this was a regression, caused by dc3d75da05c3ff2dd6510c32a11deacced49d1a1.

--

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/