Re: [RFC,v2] x86_64: save_args out of line

[Alexander van Heukelum]

On Tue, Nov 18, 2008 at 08:09:28AM +0000, Jan Beulich wrote:
> >>> Alexander van Heukelum <heukelum@xxxxxxxxxxxxx> 17.11.08 18:52 >>>
> >The macro "interrupt" in entry_64.S generates a lot of code and it
> >is used more and more often. This patch moves most of its contents
> >into an external function. This saves anywhere between 500 and 2500
> >bytes of text depending on the configuration.
> 
> Without numbers, I'd doubt that the code size reduction outweighs the
> overhead of the extra call. Did you do any measurements?

I have not measured yet. I'll see if I can highjack a machine. What
kind of benchmark would you suggest?

> >Dwarf2-annotations are most probably wrong or missing at all.
> 
> Indeed - do you have intentions to address this?

Yes, I'ld like to get it right. What do you use to check the
annotations?

Greetings,
	Alexander

> Jan
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/