Re: [PATCH 1/2] cdrom: split mmc_ioctl to lower stack usage

[Marcin Slusarz]

On Mon, Nov 17, 2008 at 01:11:34PM +0100, Jens Axboe wrote:
> On Sun, Nov 16 2008, Marcin Slusarz wrote:
> > Checkstack output:
> > 
> > Before:
> > mmc_ioctl:                  584
> > 
> > After:
> > mmc_ioctl_dvd_read_struct:  280
> > mmc_ioctl_cdrom_subchannel: 152
> > mmc_ioctl_cdrom_read_data:  120
> > mmc_ioctl_cdrom_volume:     104
> > mmc_ioctl_cdrom_read_audio: 104
> > (mmc_ioctl is inlined into cdrom_ioctl - 104 bytes)
> 
> Looks good (both 1 and 2). What kind of testing have you done? I have
> applied it to for-2.6.29.

Only very basic testing - I can play audio cd's via amarok (CDROMREADRAW)
and kscd (CDROMREADAUDIO).

Marcin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/