Re: [RFC,v2] x86_64: save_args out of line

[Andi Kleen]

On Tue, Nov 18, 2008 at 03:45:11PM -0800, Roland McGrath wrote:
> Yes, I mean a single macro that produces both the instruction and the CFI
> pseudo-op to go with it.  This is the essential characteristic that makes
> it an improvement for maintaining the code.  The main problem we have now
> is that it's easy to write/modify plain assembly instructions and forget to
> add or update the CFI to match.  A well-considered set of macros can solve
> this without making it any harder for the average assembly programmer to
> understand what each line of the source means intuitively.

Hmm, but if the assembler cannot auto generate it how should the assembler
writer know if he should use the macro or the direct instruction without
understanding CFI?

Also what will the assembler reader do? Do they first have to understand
CFI to understand everything? I personally would probably just
resort to objdump -S in this situation.

I think you're saying that for the user the macros would be just
equivalent, but if that's true they could be just auto generated 
by the assembler. But it's obviously not, so you'll end up
with the Linux magic asm dialect (and its maintenance disadvantages)
and you'll still require CFI knowledge to understand/write everything 
anyways.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/