Re: [PATCH] Parport driver: disable pc-style parport on Blackfinsystems

From: Andrew Morton
Date: Wed Nov 19 2008 - 01:36:52 EST


On Tue, 18 Nov 2008 15:12:42 +0800 Bryan Wu <cooloney@xxxxxxxxxx> wrote:

> From: Mike Frysinger <vapier.adi@xxxxxxxxx>
>
> Signed-off-by: Mike Frysinger <vapier.adi@xxxxxxxxx>
> Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx>
> ---
> drivers/parport/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/parport/Kconfig b/drivers/parport/Kconfig
> index 209b4a4..855f389 100644
> --- a/drivers/parport/Kconfig
> +++ b/drivers/parport/Kconfig
> @@ -36,7 +36,7 @@ if PARPORT
> config PARPORT_PC
> tristate "PC-style hardware"
> depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && \
> - (!M68K || ISA) && !MN10300 && !AVR32
> + (!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN
> ---help---
> You should say Y here if you have a PC-style parallel port. All
> IBM PC compatible computers and some Alphas have PC-style

Again, you overestimate our mind-reading abilities.

Some poor schmuck has to work out whether we need this patch in one,
some or all of 2.6.25.x, 2.6.26.x, 2.6.27.x, 2.6.28 and 2.6.29. This
poor schmuck cannot work that out unless you tell him what the damn
patch does!

If it fixes the build then sure, 2.6.28. If it's just a
dont-compile-this-because-we-dont-have-the-hardware thing then I'd say
2.6.29.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/