Re: [patch] sched: add locking when update the task_group'scfs_rq[] array.

From: Ingo Molnar
Date: Wed Nov 19 2008 - 02:53:42 EST



* Ken Chen <kenchen@xxxxxxxxxx> wrote:

> @@ -1513,8 +1513,12 @@ static int tg_shares_up
> unsigned long weight, rq_weight = 0;
> unsigned long shares = 0;
> struct sched_domain *sd = data;
> + unsigned long flags;
> int i;
>
> + if (!spin_trylock_irqsave(&tg->tg_lock, flags))
> + return 0;

hm, why trylock?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/