Re: [PATCH] kobject_add: use constant strings directly as fmt strings

[rae l]

On Wed, Nov 19, 2008 at 11:57 PM, Greg KH <gregkh@xxxxxxx> wrote:
>>       ret = kobject_add(&q->kobj, kobject_get(&disk_to_dev(disk)->kobj),
>> -                       "%s", "queue");
>> +                       "queue");
>
> Why?  What does this change buy us?

Dropping one parameter makes the function call a little faster, doesn't it?

The results are the same,

so if the string is constant, why not use it directly as the fmt string?

Thanks.

>
> thanks,
>
> greg k-h

-- 
Cheng Renquan, Shenzhen, China
Lily Tomlin  - "The trouble with the rat race is that even if you win,
you're still a rat."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/