Re: [PATCH 2/2] udf: reduce stack usage of udf_get_filename

[Andrew Morton]

On Wed, 19 Nov 2008 22:01:23 +0100
Jan Kara <jack@xxxxxxx> wrote:

> On Wed 19-11-08 09:35:15, Andrew Morton wrote:
> > On Wed, 19 Nov 2008 16:26:22 +0100 Jan Kara <jack@xxxxxxx> wrote:
> > 
> > > On Tue 18-11-08 16:19:38, Andrew Morton wrote:
> > > > On Sun, 16 Nov 2008 19:02:45 +0100
> > > > Marcin Slusarz <marcin.slusarz@xxxxxxxxx> wrote:
> > > > 
> > > > > +	filename = kmalloc(sizeof(struct ustr), GFP_NOFS);
> > > > 
> > > > I suspect that we could have used the superior GFP_KERNEL everywhere in
> > > > both these patches.  But I'll let Jan worry about that ;)
> > >   Definitely not in the second case - that one is called from inside
> > > readdir, lookup and symlink resolution code so that could lead to deadlocks
> > > IMHO.
> > >   Regarding the first case in process_sequence, that is called only from
> > > udf_fill_super(). So there it might be safe to use GFP_KERNEL but I'm not
> > > quite sure either... So I'd leave GFP_NOFS there.
> > > 
> > 
> > The reason for using GFP_NOFS is to prevent deadlocks when direct
> > memory reclaim reenters the filesystem code.  But I don't think there's
> > ever a case when direct reclaim would enter the namespace part of a
> > filesystem - it is only expected to touch the pagecache (ie: data)
> > operations: writepage(), block allocator, etc.
>   Hmm, but I see for example:
> static int shrink_icache_memory(int nr, gfp_t gfp_mask)
> {
>         if (nr) {
>                 /*
>                  * Nasty deadlock avoidance.  We may hold various FS locks,
>                  * and we don't want to recurse into the FS that called us
>                  * in clear_inode() and friends..
>                  */
>                 if (!(gfp_mask & __GFP_FS))
>                         return -1;
>                 prune_icache(nr);
>         }
>         return (inodes_stat.nr_unused / 100) * sysctl_vfs_cache_pressure;
> }
>   So it seems that with GFP_KERNEL, prune_icache() can be called as well
> (and similarly prune_dcache()) and that could in theory block on other
> locks, couldn't it?
> 

hm, yeah, OK, true.

iirc this only applies to weird filessytems which do complex things
(ie: take locks) in their destroy_inode/clear_inode/etc handlers.

udf_clear_inode() looks pretty complex.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/