Re: [PATCH 1/1] cpumask: smp_call_function_many()

From: Rusty Russell
Date: Wed Nov 19 2008 - 18:38:52 EST


On Thursday 20 November 2008 06:53:27 Hiroshi Shimamoto wrote:
> Rusty Russell wrote:
> > + /* Fastpath: do that cpu by itself. */
> > + if (next_cpu >= nr_cpu_ids)
> > + smp_call_function_single(cpu, func, info, wait);
>
> Hi Rusty,
>
> I think, return is needed here. If not func will be called twice.

Indeed, thanks!

Fixed,
Rusty.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/