Re: [PATCH] always assign userspace_addr

[Avi Kivity]

Anthony Liguori wrote:
> That's not how I read the code.  I see:
>
> > static void kvm_free_physmem_slot(struct kvm_memory_slot *free,
> >                   struct kvm_memory_slot *dont)
> > {
> >     if (!dont || free->rmap != dont->rmap)
> >         vfree(free->rmap);
>
> And it's called as kvm_free_physmem_slot(&old, &new);
>
> new is assigned to old to start out with so old.rmap will equal new.rmap.

Hm, if !npages we should just kvm_free_physmem_slot(&old, NULL).


--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/