Re: [PATCH 2.6.28-rc5 05/11] kmemleak: Add support for i386

[Ingo Molnar]

* Catalin Marinas <catalin.marinas@xxxxxxx> wrote:

> This patch adds the kmemleak-related entries to the vmlinux.lds.S
> linker script.
> 
> Signed-off-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> ---
>  arch/x86/kernel/vmlinux_32.lds.S |    1 +

a small detail: a better changelog would be:

|   x86: provide _sdata
|
|   Impact: provide generic symbol
|
|   _sdata is a common symbol defined by many architectures and made
|   available to the core kernel via asm-generic/sections.h.
|
|   Add it to x86 too, so that kmemleak can make use of it.

it is more informative this way, and would be in the customary x86 
commit style.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/