Re: [PATCH] intel-iommu: make init_dmars() static

From: David Woodhouse
Date: Thu Nov 20 2008 - 09:37:56 EST


On Thu, 2008-11-20 at 14:24 +0000, Mark McLoughlin wrote:
> On Thu, 2008-11-20 at 14:21 +0000, Mark McLoughlin wrote:
> > init_dmars() is not used outside of drivers/pci/intel-iommu.c
>
> Note, most of linux/dma_remapping.h is only needed by intel-iommu.c

Most.

> Any objections into moving all of that into intel-iommu.c?

That would seem to make sense. Don't forget to check IA64 when declaring
stuff unused though :)

--
David Woodhouse Open Source Technology Centre
David.Woodhouse@xxxxxxxxx Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/