Re: [PATCH 10/16] Blackfin SPI Driver: use the properl BIT_CTL_xxx defines

From: David Brownell
Date: Thu Nov 20 2008 - 15:54:38 EST


On Monday 17 November 2008, Bryan Wu wrote:
> From: Mike Frysinger <vapier.adi@xxxxxxxxx>
>
> use the properl BIT_CTL_... defines rather than the internal driv
> er CFG_SPI_... defines
>

> @@ -821,12 +821,9 @@ static void pump_transfers(unsigned long data)
> (unsigned long) (drv_data->rx +
> drv_data->len_in_bytes));
>
> - /* clear tx reg soformer data is not shifted out */
> - write_TDBR(drv_data, 0xFFFF);
> -

This is unrelated to a BIT_CTL #define. It's a bug in
either the patch or its comment.


> dma_config |= WNR;
> dma_start_addr = (unsigned long)drv_data->rx;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/