Re: [PATCH] ftrace: mcount record based dynamic tracing for ARM

[Steven Rostedt]

On Fri, 21 Nov 2008, Russell King - ARM Linux wrote:

> On Fri, Nov 21, 2008 at 09:27:17AM -0500, Steven Rostedt wrote:
> > On Thu, 20 Nov 2008, Jim Radford wrote:
> > > -	select HAVE_FUNCTION_TRACER if (!XIP_KERNEL)
> > > +	select HAVE_FTRACE_MCOUNT_RECORD
> > > +	select HAVE_DYNAMIC_FTRACE if (!XIP_KERNEL)
> > 
> > Russell mentioned something about the code not being compatible with 
> > Thumb2, is the above if statement enough?
> 
> I think I said (or should've said) "upcoming Thumb 2" - it's not yet in
> the kernel but there's a patch series floating around for it.  We've
> started on merging some of the pre-requisits, and it will mean that
> the instruction length is no longer constant.  (It may be a 16bit or
> 32bit instruction.)
> 
> I suspect that ftrace won't be able to handle that, so it may have to
> depend on !THUMB2_KERNEL for the time being.

Actually it depends on how the compiler adds the mcount call. That's all 
that ftrace touches. The call to mcount. If all callers to mcount stay as 
32 bit, then it may still work.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/