Re: [PATCH 20/32] uninorth-agp section mess

From: Benjamin Herrenschmidt
Date: Sat Nov 22 2008 - 16:53:24 EST


On Sat, 2008-11-22 at 17:36 +0000, Al Viro wrote:
> 'aperture' is declared devinitdata (the whole word of it) and
> is used from ->fetch_size() which can, AFAICS, be used on
> !HOTPLUG after init time.
>
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>

Acked-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>

> ---
> drivers/char/agp/uninorth-agp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/char/agp/uninorth-agp.c b/drivers/char/agp/uninorth-agp.c
> --- a/drivers/char/agp/uninorth-agp.c
> +++ b/drivers/char/agp/uninorth-agp.c
> @@ -27,7 +27,7 @@
> static int uninorth_rev;
> static int is_u3;
>
> -static char __devinitdata *aperture = NULL;
> +static char *aperture = NULL;
>
> static int uninorth_fetch_size(void)
> {
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@xxxxxxxxxx
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/