Re: [PATCH] create /proc/timer-wheel-list

From: Joe Korty
Date: Sat Nov 22 2008 - 20:59:52 EST


On Sat, Nov 22, 2008 at 12:34:23PM -0500, Alexey Dobriyan wrote:
> On Fri, Nov 21, 2008 at 05:11:13PM -0500, Joe Korty wrote:
> > Create /proc/timer_wheel_list.
> >
> > This does for the timer wheel what /proc/timer_list
> > does for hrtimers -- provide a way of displaying what
> > timers are running on what cpus, and their attributes.
>
> The fact that it's called a timer wheel is just an implementation detail
> unsuitable for permanent file.

Agreed. I'll come up with something else. lrtimer_list is
a good candidate.

> And you invented totally new (broken) way to print jiffies.

You'll have to be more explicit about what's broken.

> For printing nice function pointers we have %pF now.

I'll go play with that again. IIRC, the first
time I played with it, it's output was of the form
'symbol+0xoffset/0xsize' rather than just 'symbol'.

> late_initcall usage is taken out of air.

I'm open to suggestions. My thought was that it was as
good as any other initcall, since none of this stuff can
be referenced until after applications start running off
of /sbin/init. So what one picks is a bit of a crapshoot.

> Can we put all this shit in debugfs, please?

I kinda like the debugfs idea. Though there is
some attraction to making it parallel to the existing
/proc/timer_list, rather than putting it somewhere else
entirely.

I can see a migration path here .. put lrtimers_list in
debugfs, later move /proc/timers_list to debugfs (perhaps
as hrtimers_list) and make /proc/timers_list itself a
symbolic link to the debugfs version.

Regards,
Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/