Re: [PATCH 3/3] x86: signal: cosmetic unification ofsys_rt_sigreturn()

[Ingo Molnar]

* Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx> wrote:

> H. Peter Anvin wrote:
> > Hiroshi Shimamoto wrote:
> >>  
> >> +#ifdef CONFIG_X86_32
> >>  asmlinkage int sys_rt_sigreturn(unsigned long __unused)
> >>  {
> >>  	struct pt_regs *regs = (struct pt_regs *)&__unused;
> >>  
> >>  	return do_rt_sigreturn(regs);
> >>  }
> > 
> > Why not:
> > 
> > asmlinkage int sys_rt_sigreturn(struct pt_regs regs)
> > {
> > 	return do_rt_sigreturn(&regs);
> > }
> > 
> > ...?
> 
> Good question. I didn't realize about that.
> Will take a look.

I've applied your 3 patches to tip/x86/signal - please send a patch on 
top of your current lineup, for the detail Peter pointed out.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/